PHP form help

[ntl customer]

OK I've manged to generate a PHP form off some website, but I need to tweak it to my requirements

The code is as follows: -

PHP Code:

<?php
// Website Contact Form Generator 
// http://www.tele-pro.co.uk/scripts/contact_form/ 
// This script is free to use as long as you  
// retain the credit link  

// get posted data into local variables
$EmailFrom = "nobody@example.com";
$EmailTo = "nobody@example.com";
$Subject = "subject subject";
$Name = Trim(stripslashes($_POST['Name'])); 
$Email = Trim(stripslashes($_POST['Email']));
 

// validation
$validationOK=true;
if (!$validationOK) {
  print "<meta http-equiv=\"refresh\" content=\"0;URL=error.htm\">";
  exit;
}

// prepare email body text
$Body = "";
$Body = "blah blah blah";
$Body .= "\n";
$Body .= "\n";
$Body .= "Name: ";
$Body .= $Name;
$Body .= "\n";
$Body .= "\n";
$Body .= "Email: ";
$Body .= $Email;
$Body .= "\n";



// send email 
$success = mail($EmailTo, $Subject, $Body, "From: <$EmailFrom>");

// redirect to success page 
if ($success){
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ok.html\">";
}
else{
  print "<meta http-equiv=\"refresh\" content=\"0;URL=error.html\">";
}
?>

How do I get it to check that the form has been filled in correctly - and if it's not displaying an error message on screen. This form supposedly has error checking built in but it doesn't seem to work and you can type in nothing and it still says it's OK and sends a blank email.

Also, how do I get it to so that it gets IP address of the computer sending the form and the browser's user agent string so one can see what they're using - i.e. firefox/ie/opera/safari etc and pasts it in an email?

The current output in the emails is like this: -

blah blah blah

Name: ada

Email: dasdada@zzz.com

Ideally I would like it to be like this: -

blah blah blah

Name: ada

Email: dasdada

User agent: (UA string here)

IP address: (IP here)

I am not too knowledgeable on PHP, so if someone could rustle me up something then I'd be very grateful.

Thank you.

[Bifta]

You could try adding

$body .= $agent['browser'];

(with the rest of the $body content)

Can't guarantee it'll work though.

[ntl customer]

Originally Posted by Bifta

You could try adding

$body .= $agent['browser'];

(with the rest of the $body content)

Can't guarantee it'll work though.

Sadly it doesn't.

[punky]

To stop sending blank emails, the easiest way, but not most elegant would be to change this line:

PHP Code:

$success = mail($EmailTo, $Subject, $Body, "From: <$EmailFrom>"); 


to

PHP Code:


if ((isset($_GET['name'])) && (isset($_GET['email'])))
{
// send email
$success = mail($EmailTo, $Subject, $Body, "From: <$EmailFrom>"); 
}
else
{
print "<meta http-equiv=\"refresh\" content=\"0;URL=error.html\">"; 
} 


For the agent, use:

PHP Code:

$_SERVER['HTTP_USER_AGENT']; 


It works, because I have just tried it. It will output a raw string though, like: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

For IP address, your can use:

PHP Code:

$_SERVER['REMOTE_ADDR'] 


If you want the hostname, you can use $_SERVER['REMOTE_HOST'] sometimes, but if that doesn't work do

PHP Code:

gethostbyaddr($_SERVER['REMOTE_ADDR']) 


instead.

HTH

[Strzelecki]

You might want to have

PHP Code:

 $_SERVER['HTTP_X_FORWARDED_FOR'] 


to get the ips of machine that are behind proxies (NTL network) otherwise you'll just get the proxy IP.
Do you have the page error.html that it refers to when there's an error?